fix(cli-sdk): add pre-flight balance check and on-chain tx confirmation#42
Merged
fix(cli-sdk): add pre-flight balance check and on-chain tx confirmation#42
Conversation
…on to swidge 1. Pre-flight balance check: after the LI.FI quote resolves the token address, check balanceOf (ERC-20) or eth_getBalance (native) and error early with "Insufficient balance: have X, need Y" instead of sending a doomed tx to the wallet. 2. On-chain tx confirmation: poll eth_getTransactionReceipt after both approval and bridge transactions. Only report "confirmed" after receipt.status === 0x1. Throw on revert instead of silently reporting success. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…error output Catches any relay/WC errors that escape the per-request handler and prints a clean error message instead of dumping minified source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
balanceOf(ERC-20) oreth_getBalance(native) and errors early with"Insufficient balance: have X, need Y"instead of sending a doomed tx to the walleteth_getTransactionReceiptafter both approval and bridge transactions — only reports "confirmed" afterstatus === 0x1, throws on revertContext
The swidge sent 0.81 USDC when only 0.807 was available — reverted twice. Both reverted txs were reported as "confirmed" because the CLI only had the tx hash (submission), not the receipt (confirmation).
Test plan
npm run build— all packages buildnpm run test— all 107 tests pass🤖 Generated with Claude Code